search

neighbour-hoods / sensemaker-lite

11 stars 1 forks source link

Feature/91 holo core update #92

Closed pospi closed 9 months ago

pospi commented 10 months ago

Resolves #91.

adaburrows commented 10 months ago

Interesting error: https://github.com/neighbour-hoods/sensemaker-lite/pull/92/checks#step:5:1771

pospi commented 10 months ago

Still haven't been able to figure out why that is happening. Can you check if you can execute locally?

passed: 16 failed: 0 of 16 tests (48.2s)

I also want to revisit the base64 EntryHash encoding aspect to ensure nothing weird is happening with some of the BTreeHashMap return values.

pospi commented 10 months ago

Looks like we can confirm via @zippy that the expectation with any HoloHash is that to_string() will give you a Base64-encoded value. https://discord.com/channels/727959104777224303/776952534873931806/844992352710950952

pospi commented 10 months ago

Switching TypeScript module loaders seems to have been the fix- no more TS errors in CI and the tests hang indefinitely at the end as they do in a local env. Ready to merge.

adaburrows commented 9 months ago

This is already merged in somehow. I forget which PR included it.