search

neil-benn / svnrevisionlabeller

Automatically exported from code.google.com/p/svnrevisionlabeller
0 stars 0 forks source link

Make a ccnet 1.6 complient version #19

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Use the plugin with ccnet 1.6

What is the expected output? What do you see instead?
The ccnet preprocessor has problem with the minor, major, etc tokens.

to fix it, i've just replaced the {token} with [token].

Original issue reported on code.google.com by jrol...@gmail.com on 12 Jul 2010 at 10:25

GoogleCodeExporter commented 8 years ago 
A workaround is to add a space before the pattern.  I don't know the root cause.

i.e.) <pattern> {major}.{minor}.{build}.{revision}</pattern>

Original comment by wla...@gmail.com on 23 Oct 2011 at 3:55

GoogleCodeExporter commented 8 years ago 
I actually have a successful version running with the latest ccnet 1.6.7981.1.  
All i did was check out the current version, updated the ccnet dlls, and 
changed 

if (((resultFromLastBuild.LastIntegrationStatus == IntegrationStatus.Success) ||
                        IncrementOnFailure) && (revision > lastVersion.Revision)) 

in the Generate function to 

if (((resultFromLastBuild.LastIntegrationStatus == IntegrationStatus.Success) ||
                        IncrementOnFailure) && (revision == lastVersion.Revision))

Original comment by RHessinger on 2 Nov 2011 at 8:31

GoogleCodeExporter commented 8 years ago 
Forget the code changes i made, still updated the dlls to 1.6 and the project 
to .net 3.5. But i had to add in a pattern, but i had to include the major and 
minor in the pattern because msbuild was throwing errors when using a space 
before the {major} tag as said in comment 2.

Original comment by RHessinger on 3 Nov 2011 at 12:12

GoogleCodeExporter commented 8 years ago 
I have attached a patch to change the pattern from curly brackets to round 
brackets

Original comment by jan.verh...@gmail.com on 8 Nov 2011 at 1:56

Attachments:

GoogleCodeExporter commented 8 years ago 
I've forked this project onto GitHub and applied Jan's patch and added the 
CC.NET 1.6 bins.

I'm new to GitHub so I hope I did everything right.
https://github.com/neutmute/SvnRevisionLabeller

Original comment by wintermu...@gmail.com on 4 Jan 2012 at 11:58