search

neil-lindquist / lisp-paredit

Paredit for Atom
MIT License
24 stars 5 forks source link

Properly dispose of config subscriptions #16

Closed fstiewitz closed 8 years ago

fstiewitz commented 8 years ago

This is an unreported bug, but the fix is just 3 lines:

How to reproduce:

  1. Open a lisp file
  2. Disable this package
  3. Re-enable this package
  4. Disable lisp-paredit.enabled (I clicked at the status-bar indicator)
  5. Re-enable lisp-paredit.enabled

If you now try to enter a newline, you enter two. If you now try to enter an opening bracket, you enter ((|)).

My fix simply disposes the config subscriptions on deactivate by adding them to persistentSubscriptions.

Let me know what you think.

jonspalding commented 8 years ago

Thanks for the PR. Will test and release later.

jonspalding commented 8 years ago

Released in 0.5.3.