neil-lindquist / lisp-paredit

Paredit for Atom
MIT License
24 stars 5 forks source link

Added support for wrap-around #2

Closed sjlevine closed 9 years ago

sjlevine commented 9 years ago

Hello!

First of all, I'd like to thank you for your hard work on this very useful Atom package! I share your goal of improving Atom's support for Lisp-like languages. :-)

Coming from Emacs, one of my favorite paredit features was the ability to "wrap around" an expression. Say for instance I have something like "(a |b c)". Wrapping around would yield "(a (|b) c)". Use it all the time.

This pull request adds support for wrap-around to your very nice package. What do you think? Perhaps once cause for concern is that it always uses '(' and ')' and not other types of parens / brackets - not sure if you have any thoughts about that.

Thanks again for your work!

Cheers, Steve

P.S. I've been developing an atom package myself, atom-slime. It's in the very early development stages, but aims to make Atom a full-fledged Lisp IDE. With a Lisp process running an unmodified Swank server from the Slime project, this package will connect to it, offer a REPL, autocomplete, "go to definition", and more. It's still pretty rough and in development.

jonspalding commented 9 years ago

Hi,

Thanks for the pull request.

Unfortunately I didn't have notifications setup on this repo (no idea why it didn't auto-subscribe) so hadn't noticed it until now and I implemented the same functionality myself about the same time.

Needless to say I've set up notifications now, thanks for taking the time to send this pull request and I'll be sure to action any future ones quicker!

RE: atom-slime. I started something similar myself but based around CIDER when Atom first came out. It's quite out of date now as I haven't kept it in sync with the changing Atom APIs but I'll take a look at yours and maybe we can collaborate.