search

neil-lobracco / tracker

0 stars 0 forks source link

Adding a new player places the player at the end of the list i.e. not sorted #1

Closed NicholasMohr closed 6 years ago

NicholasMohr commented 6 years ago

You could say this is intentional or not worth fixing but just figured I would give the opportunity for thought!

Also I get to be the first issue on this repo 🎉

neil-lobracco commented 6 years ago

Good point! The server sorts them by Elo rating, but when creating, we just add it directly to the list rather than refetch the list of players. It should be simple enough to just insert it into the correct spot.

neil-lobracco commented 6 years ago

Fixed in https://github.com/neil-lobracco/tracker/commit/d9fc4678ba2d19feff97a2e8d7cea45b8b455e3d , in production.