neil-morrison44 / pocket-sync

A GUI tool (Mac, Windows, Linux) for doing stuff with the Analogue Pocket
GNU Affero General Public License v3.0
669 stars 25 forks source link

NSIS Installer availability for winget #322

Closed shock0572 closed 1 month ago

shock0572 commented 1 month ago

The current situation for the all the installers: image

Would it be possible to have the NSIS installer directly listed in the releases with a suffix (e.g. nsis.exe) instead of a zip file? The reason I'm asking is that, once it's directly in that format, I could issue a pull request for the winget package (https://github.com/microsoft/winget-pkgs) which natively supports nullsoft installers and have it automated for everyone to enjoy it

This is how it currently looks like in winget, only available as "interactive"

neil-morrison44 commented 1 month ago

https://github.com/tauri-apps/tauri-action

This is what generates the files, I’m not sure if there’s a config option for doing that but if there is I’m alright with having it turned on.

I’m expecting the files / config to change a little soon once Tauri V2 exits its Release Candidate phase & becomes the released version.

shock0572 commented 1 month ago

nevermind, for some reason I was mislead by the file naming (see the action code here: https://github.com/tauri-apps/tauri-action/blob/dev/src/build.ts#L149) leading me to believe that wasn't the nullsoft installer Apparently, not only it is, but it supports the /S (silent install) flag that I've tested, I will modify my winget package to accept it

shock0572 commented 1 month ago

I've put a new pull request to correct it after testing it, you can find it here: https://github.com/microsoft/winget-pkgs/pull/175276

I'm closing the issue