search

neilalexander / seaglass

A truly native Matrix client for macOS - written in Swift/Cocoa, with E2E encryption support
Other
525 stars 34 forks source link

Expand input field (#45) #83

Closed aaronraimist closed 5 years ago

aaronraimist commented 6 years ago

So... this works pretty well but it is based on some code in a GitHub gist and StackOverflow answer without any license. I'm sure they are fine with people using it but I added a comment asking if they would explicitly license it. Not sure if you are comfortable merging this without that.

https://gist.github.com/entotsu/ddc136832a87a0fd2f9a0a6d4cf754ea

Only bug is, it doesn't shrink back down until you type the first letter. I'm sure that is a simple fix but I'm just not seeing it.

aaronraimist commented 6 years ago

Oh and it breaks controlTextDidChange (why?) and therefore typing notifications, which I was in the process of trying to fix for #8

neilalexander commented 6 years ago

Are typing notifications still broken on this PR?

aaronraimist commented 6 years ago

Yes. Not sure why.

I haven't had time looked at this PR since I created it.

neilalexander commented 6 years ago

No problem - I can take a look shortly :-)

aaronraimist commented 6 years ago

It might be worth writing some tests to make sure things are working. I wouldn't have even noticed typing notifications broke here except I was going to try to fix those too.