search

neilang / NAMapKit

Allows you to use custom maps in iphone applications and attempts to mimics some of the behaviour of the MapKit framework
MIT License
263 stars 52 forks source link

Updates travis' xcode to 7.2, re-adds tests #48

Closed orta closed 8 years ago

orta commented 8 years ago

Didn't realise #46 basically removed all tests, sorry about that - really shouldn't have merged. We rely on NAMapKit a lot, I don't feel good about having it without any tests.

Looks like the new snapshots were recording the new snapshots on a 9.0, but they were still being ran against 7.0. Apple will have made rendering changes between the two major versions. This fixes that.

This should fix #47

tonyarnold commented 8 years ago

Thanks @orta.

dblock commented 8 years ago

That's the spirit, @orta gets my :100: and gets to keep his job as Cocoapods Design Dictator. Was a close call though :)

tonyarnold commented 8 years ago

Ehhhh, somehow I doubt anyone can take @orta's dictatorial open source design leanings away from him 😀

I still think visual diffs as tests are a fragile time sink, but you guys are obviously making use of them at Artsy (to your own success) so I'm not going to argue for their continued removal based on my opinion alone.

dblock commented 8 years ago

Thanks @tonyarnold. Happy to hear what the alternative is, NAMapKit could be a good test case for whatever you think works better to test UI.

tonyarnold commented 8 years ago

@dblock conversation mode: activate :grinning:

Sorry, I guess I wasn't clear: my "alternative" is to choose not to test UI in such a static manner (comparing screenshots saved into the repo to live screen captures).

If you have the extra resources to throw at something like this on projects, then yeah, I agree that it can be a help — but I personally don't work on any teams where we have the time or people to burn on testing of this nature.

In this case, you guys have done all of that work already so the conversation is moot. I find it super interesting that your team has made this kind of test important :+1: