Enable the option to resize Actor and Monster sheets

[TarkanAl-Kazily]

Hi! I started an OSR game with Whitehack3e as a base and am thinking about tinkering my own Foundry system / OSR Hack. I wanted to get some practice first with a well designed system to learn the tools and best practices, so I decided to tweak some CSS.

I'm not sure if resizing is desired for your system or if the fixed size windows was a purposeful decision, but in my opinion flexible windows helps people who need to support different font sizes and supports the totally infrequent use case where players hoard every item possible under the sun and want to expand their sheet to view more at once. Plus, the notes field is soooo small by default, so resizing the sheet makes editing that text more natural.

Summary of changes:

• Adds a gulp deploy command to quickly copy the Whitehack3e build output to a local install of FoundryVTT for development testing. This could be cherrypicked and removed if desired or updated to support non-Linux platform install directories.
• Adds resizable: true to the Javascript ActorSheet and MonsterSheet classes.
• Updates the CSS of the ActorSheet fixed_header elements which make up the table header entries for Gear, Armor, Weapon etc. tabs. The change *-name { width: 100% } enables the Name field to expand to fill the space. The change item-* { width: min-content } makes the icon columns on the left and right of each table the minimum width possible regardless of sheet width.
• Moves default Monster and Actor sheet size magic constants to the Javascript constants file.
• Updates the tabs on the ActorSheet behavior to have a fixed height instead of a flexible one.
• Updates the table body to extend fully and enable scrolling the ActorSheet to view more entries.

TODO: The Notes editor box doesn't resize properly yet, so there's still more work to do. Still, comments are appreciated!

[neilbenson]

Hi Tarkan,

Thanks for your feedback, I really appreciate you taking the time to dig into the code and putting this PR together. The decision to have a fixed window size was a conscious one - I know there are a number of paid for systems that do this such as Forbidden Lands from Free League and at the time I felt it was neater. I can see the argument for making it a resizable window though, I don't see any reason not to do it so long as the default window size is consistent.

Leave it with me, I'll try to get around to it soon.

Neil

[neilbenson]

I've just taken a quick peak, it looks good to me as the resize is entirely optional. If I get the time I'll take a look at the notes textarea.

I'm running a couple of games early this week, I'll get feedback from my players. If they approve (and I don't see why they wouldn't), I'll merge in your PR.

Thanks!

[TarkanAl-Kazily]

Thanks Neil for taking a look!

I can finish figuring out how the Notes box can be resized. I've also got a couple other ideas I want to make PRs for so I'll make those as issues first so they're all out there.

Looking forward to hearing what your players think :)

--Tarkan

[TarkanAl-Kazily]

Okay, I think I've got the fixes for the notes sheet in. I leave this PR in your hands!

[neilbenson]

Hi Tarkan, I want to give you credit in the release notes for your contribution, do you have a Twitter handle or similar that I should use?

[TarkanAl-Kazily]

Sorry for the wait - this rebase and a force push should meet satisfy the required change. Now this PR is just checking in changes related to resizing the actor and NPC sheets.

If you want to credit me in the release notes, I think using my GitHub handle (TarkanAl-Kazily) would be ideal. I appreciate it!

[neilbenson]

Released, thanks for doing this