search

neilbrown / wiggle

apply rejected patches and perform word-wise diffs
http://neil.brown.name/wiggle
GNU General Public License v2.0
91 stars 8 forks source link

Wiggle segv. #1

Closed rustyrussell closed 11 years ago

rustyrussell commented 11 years ago

$ wiggle -r lib/iomap.c lib/iomap.c.rej Aborted (core dumped) $ wiggle --version wiggle 0.9 2012-05-14 GPL-2+ http://neil.brown.name/wiggle/ (Actually, this is git latest... why is version number wrong?)

Hmm, I can include images, but not source files? Bah! I dropped them in http://ozlabs.org/~rusty/wiggle/

Cheers, Rusty.

neilbrown commented 11 years ago

Thanks for the report. I've uploaded a fix which seems to do the right thing for your test case, and doesn't break any of mine (though it lead to a slight revision of one of them).

What version number did you want? Maybe I should call it "0.9-post" until I create another release? I don't really like "-pre" naming...

rustyrussell commented 11 years ago

NeilBrown notifications@github.com writes:

Thanks for the report. I've uploaded a fix which seems to do the right thing for your test case, and doesn't break any of mine (though it lead to a slight revision of one of them).

What version number did you want? Maybe I should call it "0.9-post" until I create another release? I don't really like "-pre" naming...

Why do a pre-release? I know how to use git :)

Thanks, Rusty.

neilbrown commented 11 years ago

I wasn't suggesting a pre-release. You seemed to be suggesting that the release number reported by wiggle-compiled-from-git, being the same as that reported by the previous release, was somehow wrong. I don't dispute that, but presumably having it report the same release number as the will be reported by the next release would be equally wrong. So I was wondering aloud what sort of release number "should" be presented, and observed that I don't think much of any of the common alternatives. Maybe I should get it to add the current git id somehow: 0.9+d14ebb2 ??

rustyrussell commented 11 years ago

NeilBrown notifications@github.com writes:

I wasn't suggesting a pre-release. You seemed to be suggesting that the release number reported by wiggle-compiled-from-git, being the same as that reported by the previous release, was somehow wrong. I don't dispute that, but presumably having it report the same release number as the will be reported by the next release would be equally wrong. So I was wondering aloud what sort of release number "should" be presented, and observed that I don't think much of any of the common alternatives. Maybe I should get it to add the current git id somehow: 0.9+d14ebb2 ??

Oh, that. Sorry for being obtuse.

Yes, it's normal to use git describe to generate version numbers. Is that not an option here?

Cheers, Rusty.

neilbrown commented 11 years ago

Yes it is an option but I hadn't thought to do it. Now I have thought and have done.

$ ./wiggle -V wiggle v0.9-71-g6a994ca 2013-03-28 GPL-2+ http://neil.brown.name/wiggle/

Thanks, NeilBrown