Fix very minor memory leaks in do_merge()

neilbrown / wiggle

apply rejected patches and perform word-wise diffs

http://neil.brown.name/wiggle

GNU General Public License v2.0

91 stars 8 forks source link

Fix very minor memory leaks in do_merge() #16

Closed smcameron closed 4 years ago

smcameron commented 4 years ago

Signed-off-by: Stephen M. Cameron stephenmcameron@gmail.com

neilbrown commented 4 years ago

Thanks for the patch, but could you make one small change please. It is ok to pass NULL to free () so please remove the test before the last two frees.

smcameron commented 4 years ago

Alright, done (in a separate commit... or did you want me to squash it and amend my commit history?... I'll have to figure out how.)

neilbrown commented 4 years ago

If you change the code and "git commit --amend -a" then you can amend the top commit. Then "git push -f ...." will replace the commit on github. While I was expecting a single commit, I'm not really that fussy. I've merged you changes. Thanks!