Feature request - return WLED API XML response

neilenns / node-red-contrib-wled2

NodeRed node for controlling WLED

MIT License

19 stars 8 forks source link

Feature request - return WLED API XML response #78

Closed TheOriginalMrWolf closed 3 years ago

TheOriginalMrWolf commented 3 years ago

Hi,

Thanks for the useful node!

As an enhancement, could you please add the WLED API XML response to the returned msg (rather than just the msg that was received as input).

Thanks!

neilenns commented 3 years ago

This would be a breaking change I'm not keen to do. I think the better approach is to add a new node that simply returns the current state, as requested in #79

TheOriginalMrWolf commented 3 years ago

@danecreekphotography Oh - I had thought you could just add another attribute (containing the XML) to the existing returned message (eg msg.responseXML) , which should avoid breaking anything, no?

Either way, thanks for looking at it so quickly 👍

neilenns commented 3 years ago

I don't think there's any point to doing this, it wouldn't offer any value over just using a web request node to query the state from the device. It's a trivial API: just web request to http://ipaddress/json/state and you will get the full current state back in much more detail than I'd ever expose from the node.