neilenns / node-red-contrib-wled2

NodeRed node for controlling WLED
MIT License
19 stars 8 forks source link

Feature/disable settings from node #86

Closed daredoes closed 3 years ago

daredoes commented 3 years ago

Fixes #80

Description of changes

Checklist

If your change touches anything under src or the README.md file these items must be done:

Before

Screen Shot 2020-12-05 at 2 11 49 PM

After

Screen Shot 2020-12-05 at 2 12 42 PM
neilenns commented 3 years ago

Thanks for the pull request! This is a pretty big refactor of the code so it'll take me a bit to go through it. At first glance here are a few things to address:

  1. There are lint failures due to "warp" being unused, this should get removed.
  2. Lint failures too due to use of "any". I believe you can resolve this by using on the method then specifying the appropriate type when calling it.
  3. All new functions need JSDoc-style comments on them to explain what they do and what the parameters are.

A couple more comments added inline for now.

Edit: Ignore the JSDoc thing, I was thinking of my other side project.