search

neilff / redux-ui-router

ngRedux bindings for Angular UI Router
MIT License
143 stars 48 forks source link

stateChangeStart action creator doesn't include final options argument #62

Closed markisadesignerd closed 8 years ago

markisadesignerd commented 8 years ago

UI-Router passes the options Object to its $stateChangeStart handler. The redux implementation just drops it from the action creator. The options Object can be useful for middlewares.

Here's the ui-router implementation:

$rootScope.$on('$stateChangeStart', 
function(event, toState, toParams, fromState, fromParams, options){ ... })

PR here: #63

hally9k commented 8 years ago

Pushed a patch to fix this here