search

neilff / redux-ui-router

ngRedux bindings for Angular UI Router
MIT License
143 stars 48 forks source link

Adding `options` parameter to onStateChangeStart action creator #63

Closed markisadesignerd closed 8 years ago

markisadesignerd commented 8 years ago

UI-Router passes the options Object to its $stateChangeStart handler. The redux implementation just drops it from the action creator. The options Object can be useful for middlewares.

Here's the ui-router implementation:

$rootScope.$on('$stateChangeStart', 
function(event, toState, toParams, fromState, fromParams, options){ ... })
hally9k commented 8 years ago

Hi @markisadesignerd! I had a little look at this today. We have recently merged in the first version of support for ui-router 1.0 beta so a few things have changed around a bit. Do you want to have another look at this and re submit a PR so that I can merge your commits rather than my redo of this. I think your point is totally valid. I've just started to try and help maintain this repo as the owner hasn't had the time and gave me permissions to try and keep things moving. Sorry this took so long 😞 ... Thanks again!

hally9k commented 8 years ago

Pushed a patch to fix this here.