neilff / redux-ui-router

ngRedux bindings for Angular UI Router
MIT License
143 stars 48 forks source link

Unable to run via npm dependency but working if I copy files directly #69

Closed chandanpasunoori closed 8 years ago

chandanpasunoori commented 8 years ago

I dont know what messing in my configuration of structure but If I install as npm dependency its not its not triggering when states changes.

but if I copy this projects files its working properly.

I'm tried with your example also bahavior is same.

I can't post my code so attaching images

working one (redux-router is close of this repo) image

not working (see after from in import) image

same with your example directory

working image

not working image

log out for working when importing from cloned files image

not working here if importing as npm dependency image

can you please tell me, what I'm doing wrong?

chandanpasunoori commented 8 years ago

I'm using 0.6.0 version from npm... will 0.6.1 solve this issue ?? anyhow its not published yet

hally9k commented 8 years ago

Hi @etsrepo, Which version of ui-router have you got installed?

hally9k commented 8 years ago

Unable to reproduce this end so I've closed this for now. Feel free to pick it back up at any time.

chandanpasunoori commented 8 years ago

my project dependencies

    "angular-ui-router": "^1.0.0-beta.2",
    "angular": "^1.5.8",
    "ng-redux": "^3.4.0-beta.1",
    "react-redux": "^4.4.5",
    "redux": "^3.6.0",
    "redux-devtools": "^3.3.1",
    "redux-logger": "^2.6.1",
    "redux-thunk": "^2.1.0",
    "redux-ui-router": "^0.6.0"

your example dependencies

{
  "name": "angular-ui-router-redux",
  "version": "0.1.0",
  "main": "index.js",
  "scripts": {
    "start": "npm install; node server.js",
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "devDependencies": {
    "babel-loader": "6.2.4",
    "babel-core": "6.13.1",
    "redux-batched-updates": "0.1.0",
    "react": "^15.3.0",
    "react-dom": "^15.3.0",
    "redux-devtools-dock-monitor": "^1.1.1",
    "redux-devtools-log-monitor": "^1.0.11",
    "redux-slider-monitor": "^1.0.7",
    "webpack": "1.13.1",
    "webpack-dev-server": "1.14.1"
  },
  "license": "MIT",
  "dependencies": {
    "angular": "^1.5.1",
    "angular-ui-router": "1.0.0-beta.1",
    "ng-redux": "^3.3.3",
    "react-redux": "^4.4.5",
    "redux-devtools": "^3.3.1",
    "redux": "^3.5.2",
    "redux-logger": "2.6.1",
    "redux-thunk": "2.1.0",
    "redux-ui-router": "^0.6.0"
  },
  "engines": {
    "node": "6.3.0",
    "npm": "3.10.3"
  }
}
hally9k commented 8 years ago

@etsrepo - The version 0.6.0 doesn't have support for angular-ui-router 1.0 beta. The current state of master, which is marked 0.6.1, will be released as 0.7.0 because it brings support for angular-ui-router 1.0 but we won't release this until angular-ui-router 1.0 comes out of beta, I expect. If you roll back your angular-ui-router version to 0.3.1 then redux-ui-router 0.6.0 will work for you. Sorry about that. Maybe this should be more clear in the docs and an explicit peer dependency... Hmmm I'll have a think about it. Hope this helps!