Npm umd packages - Githubissues

neilff / redux-ui-router

ngRedux bindings for Angular UI Router

MIT License

143 stars 48 forks source link

Npm umd packages #89

Closed kaidjohnson closed 7 years ago

kaidjohnson commented 7 years ago

Following up on #88 I realize we were bundling angular and angular-ui-router in the resulting library, which is bad form.

I've added a light webpack config to require angular and angular-ui-router as external libraries. This brings the bundle sizes down from 1.48M/221K (dev/prod) to 58K/12K and build times from 730ms/3000ms to 240ms/500ms.

hally9k commented 7 years ago

@kaidjohnson good spotting. Do you want to check that the published packages v0.7.1-rc.3 and v0.6.3 to make sure that's all gone smoothly? Many thanks again for your contribution.