search

neilharvey / FileSignatures

A small library for detecting the type of a file based on header signature (also known as magic number).
MIT License
250 stars 41 forks source link

OpenMCDF instead of OpeMCDF-2 ? #21

Closed JiriZidek closed 4 years ago

JiriZidek commented 4 years ago

Have you considered changing dependency from https://github.com/CodeCavePro/OpenMCDF (OpenMCDF-2) to https://github.com/ironfede/openmcdf (OpenMCDF) that looks better maintained ?

neilharvey commented 4 years ago

Hey, I wasn't aware of OpenMCDF, the OpenMCDF-2 dependency came in via a PR.

Comparing the code bases, it looks as though OpenMCDF-2 was a fork of OpenMCFD which only has a single contributor so I think you're probably right, OpenMCDF will likely have better maintenance in the long-term.

JiriZidek commented 4 years ago

I just noticed these two met side-by-side in one of my project, so I studied how this had happened....

neilharvey commented 4 years ago

I did wonder what lead you to spot it :)

neilharvey commented 4 years ago

This has been changed in v4.0.

mexvod commented 4 years ago

Why did you change the library? Now you will be illegally processed compound storage formats.

neilharvey commented 4 years ago

@mexvod As discussed above, the dependency was changed because OpenMCDF-2 appeared to be a fork with fewer maintainers. It appears that they have the same licence?

https://github.com/ironfede/openmcdf/blob/master/License.txt https://github.com/CodeCavePro/OpenMCDF/blob/master/LICENSE.md

mexvod commented 4 years ago

Yes it is. But version 2 of the library had the correct file processing algorithm, unlike the original. I need to conduct additional tests to determine the correct operation.

JiriZidek commented 4 years ago

1 - in what sense do you mean "correct" ? 2 - maybe it is time to file an Issue at the original project and suggest a fix ?