search

neilharvey / FileSignatures

A small library for detecting the type of a file based on header signature (also known as magic number).
MIT License
250 stars 41 forks source link

Signed assembly (strong-named) #38

Closed gigi81 closed 3 years ago

gigi81 commented 3 years ago

Hi, We would like to use FileSignatures in a project that is strongly named (signed).

From the docs: A strong-named assembly can only use types from other strong-named assemblies. Otherwise, the integrity of the strong-named assembly would be compromised. https://docs.microsoft.com/en-us/dotnet/standard/assembly/create-use-strong-named

Would it be possible to sign the assembly that is in the nuget package. I'm happy to have a PR for this, just wondering if it is something that would be open to. All dotnet libraries usually comes strongly named (signed) including the dotnet core ones.

neilharvey commented 3 years ago

Hey, yep I'm happy to do that - if you send a PR I'll republish a new package.

gigi81 commented 3 years ago

fantastic @neilharvey I will try and do that today then. thanks!

neilharvey commented 3 years ago

Thanks for the PR - I've published the new version as 4.1 - https://www.nuget.org/packages/FileSignatures/4.1.0. Gimme a shout if any issues.

gigi81 commented 3 years ago

Tested and it works fine. Thank you very much for such a fast turnaround! Closing as fixed.