search

neilime / zf2-assets-bundle

AssetsBundle is a module for Zend Framework 2 allowing asset managment (bundling & caching)
https://neilime.github.io/zf2-assets-bundle/
MIT License
33 stars 20 forks source link

Added cdnUrl check #27

Closed dmregister closed 9 years ago

dmregister commented 10 years ago

Added a check that if the cache url host is different than that request uri host, skip the cachePath check and file exists check.

neilime commented 10 years ago

Please fix the failing phpunit tests

dmregister commented 10 years ago

@neilime I am not sure what this test is trying to accomplish.

//the test https://github.com/dmregister/zf2-assets-bundle/blob/0a8d44509e04cca680953f357138cbcff74f6e77/tests/AssetsBundleTest/Controller/ToolsControllerTest.php#L132

//where the exception is being thrown https://github.com/dmregister/zf2-assets-bundle/blob/0a8d44509e04cca680953f357138cbcff74f6e77/src/AssetsBundle/Service/ServiceOptions.php#L151

I created a new branch before my code commits and the exception still exists.

The exception is also on the current build in travis: https://travis-ci.org/neilime/zf2-assets-bundle/jobs/26219438

Let me know how you want to handle this.

Thanks.

dmregister commented 10 years ago

@neilime are there any other updates I should make before you can merge the request?

dmregister commented 9 years ago

@neilime were you able to look into this pull request?

neilime commented 9 years ago

Please can you resolve the conflicts, so I will be able to merge this pull request

dmregister commented 9 years ago

@neilime you can delete this pull request. The module has changed drastically since I submitted it. I will open another pull request with the fix at a later date.