search

neilime / zf2-assets-bundle

AssetsBundle is a module for Zend Framework 2 allowing asset managment (bundling & caching)
https://neilime.github.io/zf2-assets-bundle/
MIT License
33 stars 20 forks source link

Bug #56 fix : Avoid 404 error on empty CSS generated #57

Closed wambaloo closed 7 years ago

wambaloo commented 7 years ago

Pull request to correct empty CSS generation.

neilime commented 7 years ago

Thank your for this PR @wambaloo, can you fix the broken phpunit tests please ?

wambaloo commented 7 years ago

Hi Neilime !!

Sorry for this late answer but I'm in really in rush in my project actually so I can't spend time trying to correct this test failure. I try this morning, passing 2 hours on it but without success. I'm not familier with phpunit tests and I don't understand why the "dispatch" does not work... So I can't do antything for the moment because I really don't have the time for this... If you can see what's wrong with that it could be a plus for your bundle, or maybe help me to debug this...

Thanks in advance and sorry...

neilime commented 7 years ago

Hi @wambaloo, I've made severals modifications on your branch to made tests work. Please can you test that it works for you as expected ? Thanks