search

neilime / zf2-twb-bundle

Zend Framework module for easy integration of Twitter Bootstrap
http://neilime.github.io/zf2-twb-bundle/
MIT License
143 stars 94 forks source link

FormLabel is incompatible with formLabel from ZF2 #186

Open guilherme-santos opened 8 years ago

guilherme-santos commented 8 years ago

Hi,

https://github.com/neilime/zf2-twb-bundle/blob/master/src/TwbBundle/View/Helper/TwbBundleLabel.php#L33 In this line you're expecting for a string while FormLabel from ZF2 is expect an element https://github.com/zendframework/zend-form/blob/master/src/View/Helper/FormLabel.php#L43 you should remain compatible, right?

neilime commented 8 years ago

Hi,

The class TwbBundle\View\Helper\TwbBundleLabel does not render form label, it renders bootstrap label (http://getbootstrap.com/components/#labels)

guilherme-santos commented 8 years ago

That's true, so the bug is here: https://github.com/neilime/zf2-twb-bundle/blob/master/config/module.config.php#L71 https://github.com/neilime/zf2-twb-bundle/blob/master/config/module.config.php#L89

neilime commented 8 years ago

You're right ! I have fixed the config, please let me know if it works for you now

Thank you