neilpatel121 / homebridge-skyq-tvremote

Apache License 2.0
10 stars 3 forks source link

Refactor for multiple devices #11

Closed SmolSoftBoi closed 3 years ago

SmolSoftBoi commented 3 years ago
neilpatel121 commented 3 years ago

Is this a breaking change cause of the configuration? Does it require a major version change?

neilpatel121 commented 3 years ago

Thanks for sorting out a single instance plugin

SmolSoftBoi commented 3 years ago

Is this a breaking change cause of the configuration? Does it require a major version change?

No, this is not a breaking change, users using the existing configuration(s) will continue to work, if the new configuration is detected, then it will use that instead.

The schema update does mean that anyone using the existing configuration(s) will need use the new configuration, but only if they need to update their configuration.

neilpatel121 commented 3 years ago

Hey Kris, please send me your npm id, so you can publish yourself

SmolSoftBoi commented 3 years ago

Hey Kris, please send me your npm id, so you can publish yourself

epickris

neilpatel121 commented 3 years ago

Hey Kris you should be able to Nom publish now

SmolSoftBoi commented 3 years ago

Hey Kris you should be able to Nom publish now

I don't have access to the repository settings, could you add a new Repository Secret: https://github.com/neilpatel121/homebridge-skyq-tvremote/settings/secrets/actions/new

Name: NPM_TOKEN Value: npm Automatation Access Token: https://www.npmjs.com/settings/neilpatel121/tokens/create

neilpatel121 commented 3 years ago

Hey Kris,

Followed your instructions, this is done

Neil On 15 Apr 2021, 20:39 +0100, neilpatel121/homebridge-skyq-tvremote @.***>, wrote:

Name

SmolSoftBoi commented 3 years ago

Hey Kris, Followed your instructions, this is done Neil

Hey Neil, great, you can now use GitHub releases to publish new versions, including betas, to npm.

neilpatel121 commented 3 years ago

Nice one Kris, beats doing manual publish.. git deployment is new to me

SmolSoftBoi commented 3 years ago

Nice one Kris, beats doing manual publish.. git deployment is new to me

Just ensure the package.json version has been updated to the correct value before creating a new release. 👍🏻