neilpatel121 / homebridge-skyq-tvremote

Apache License 2.0
10 stars 3 forks source link

Switch channels via Siri #20

Closed michel0271 closed 3 years ago

michel0271 commented 3 years ago

Hello, will it be possible to switch channels via Siri in a future version? I already have such a plug-in for my Sony TV and it is then implemented using scenes. Greetings Michel

SmolSoftBoi commented 3 years ago

It still has the same behaviour in that the previously selected input persists even if the channel is changed or the box is power cycled.

Is there an endpoint to get the current channel that you're aware of?

benfysh commented 3 years ago

It still has the same behaviour in that the previously selected input persists even if the channel is changed or the box is power cycled.

Is there an endpoint to get the current channel that you're aware of?

not that I am aware of

SmolSoftBoi commented 3 years ago

Is there an endpoint to get the current channel that you're aware of?

not that I am aware of

Not that I could find either, I don't think there's a way around this issue without being able to grab that information.

neilpatel121 commented 3 years ago

been having a look around, this like the HA community have managed to do this,

https://github.com/RogerSelwyn/Home_Assistant_SkyQ_MediaPlayer

neilpatel121 commented 3 years ago

can't find now typescript or js implementations, seems quite involved, with soap request, better reference implantation here..

https://github.com/4n0nD3v3l0p3r/Home_Assistant_SkyQ_MediaPlayer/blob/master/skyq/sky_remote.py

SmolSoftBoi commented 3 years ago

@neilpatel121 Great find, I'm going to create a separate library so we can utilise this, it even has device discovery.

michel0271 commented 3 years ago

I have no idea what you're doing, but I'll be there ... First Beta Tester 😂👍🏼

SmolSoftBoi commented 3 years ago

So I can't test the Soap requests because I don't have access to a Sky Q yet.

benfysh commented 3 years ago

So I can't test the Soap requests because I don't have access to a Sky Q yet.

Let me know if I can help in any way.

Thanks for all you've done with this plugin considering you don't have a Sky Q box!

SmolSoftBoi commented 3 years ago

For now I've released this as is. #19 has been fixed and this feature is almost done. And will re-visit this again soon.

I have started developing a library at https://github.com/EpicKris/node-sky-q, you're welcome to test that as is if you'd like, however the Soap part hasn't been fully built out yet.

michel0271 commented 3 years ago

Will you continue to work on the plugin? E.g. faster switching times? greetings michel

SmolSoftBoi commented 3 years ago

Will you continue to work on the plugin? E.g. faster switching times? greetings michel

The actual speed of switching cannot be increased, it currently works by "backing up" and then entering the channel number as if it were a remote. I'm not aware of any other way of changing the channel currently.

michel0271 commented 3 years ago

ok

ngem1 commented 3 years ago

Can we have an option to not have channels listed? It shows as 97 off on my favourites page which means you cannot easily power cycle from the control centre. The LG web OS plug in for example has an option for channel control/volume control etc

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SmolSoftBoi commented 3 years ago

Could you test v1.3.0-beta.0?

benfysh commented 3 years ago

Could you test v1.3.0-beta.0?

Favourites are now being loaded as 'Inputs' on the box where I have them set instead of the first 100 channels. On boxes without favourites no 'Inputs' are being loaded. Not sure if this is what you are expecting?

The input is also not synced with the actual channel on the box assume you are not getting the state yet?

The issue persists that on the first open of the home all inputs are shown as switches as opposed to selectable inputs. Killing and reopening the home app resolves this.

IMG_27AC1FF3A03B-1

SmolSoftBoi commented 3 years ago

So I'm trying to use the favourites from the Sky box for the input list instead of the first 100 channels.

Could you send me a full screenshot please?

benfysh commented 3 years ago

Sure:

After restarting homebridge only on first load of the home app:

IMG_7EF33F3D66F0-1

After killing and reopening the home app.

IMG_D3B9DD6FC4B1-1

SmolSoftBoi commented 3 years ago

The latest screenshot appears to be expected behaviour?

benfysh commented 3 years ago

The latest screenshot appears to be expected behaviour?

Yes, it just requires you to kill and reopen the home app (even if wasn't running previously) in order to get the expected behaviour. Minor in the scheme of things and may be on the iOS as opposed to the plugin side.

SmolSoftBoi commented 3 years ago

Yes, it just requires you to kill and reopen the home app (even if wasn't running previously) in order to get the expected behaviour. Minor in the scheme of things and may be on the iOS as opposed to the plugin side.

Oh yes, I experienced the same issue, but does seem to be an iOS issue, tried with a couple of different devices.

simon3163 commented 2 years ago

Hi Both, Was this resolved - i can't see the inputs when i load this plugin into Home?

Thanks

simon3163 commented 2 years ago

This is what I use to use Siri to change sky channels

Does this still work, if so how? Could you let me see the code?

SmolSoftBoi commented 2 years ago

@simon3163 Please open a new issue.