search

neilpeterson / azure-blueprints-pipeline-tasks

MIT License
17 stars 16 forks source link

Issue: Assignment fails when a string is use for blueprint version #11

Open neilpeterson opened 5 years ago

neilpeterson commented 5 years ago

Scenario: Blueprint exists with a version of version1. A task is used to update the blueprint and the task is set to increment the version.

This will not work / how should we handle?

neilpeterson commented 5 years ago

If the initial version is a string, and the task is changed to implement the increment functionality, the request fails.

##[error]Cannot convert value "test-version" to type "System.Int32". Error: "Input string was not in a correct format."

a) I will fix the issue b) I'm wondering if the incrementing functionality should be removed from the task.

stefanpetter commented 4 years ago

Maybe the increment can look for the last number in a string? For example, if there is a blueprint with version 1.2.1, to version will be updated to version 1.2.2. If it is 1.4, it will be 1.5. Major changes in a blueprint will be more likely to me rolled out piece by piece anyway, I think.

neilpeterson commented 4 years ago

Thanks @stefanpetter .

I think given the extension will already handle the examples as you've described. Where it blows up is the version is a sting, for example v1.

I've not yet received any related issues or requests to fix, so have not put any priority on this one. I will get to it someday and raise the priority if it becomes an issue for anyone using the extension.