neilpl24 / pierreanalyticsource

6 stars 2 forks source link

Team pages #19

Closed bsummy closed 7 months ago

bsummy commented 8 months ago

Fixes #6

Buckle Up - this is a big one. I hope that you'll take a look over everything when you get some time, seeing as this is my first larger commit. It also took care of a couple smaller issues that I noticed around the app, but I'll try to note them here:

There's two things that I want to include before this is merged

  1. need to make sure I'm not overwriting the .db files, so after you approve, I need you to take the SQL statements (in backend/sql) and run them in the most up to date version of player_stats.db. I'll remove any changes I made to the db files from the commit.
  2. if possible, can I get the default current timestamp added to the team stats db? if you look at the standings page you'll see what I plan to do.

Something I've been meaning to ask:

neilpl24 commented 8 months ago

Do you have it setup to write new sets of standings to the same table and not drop/recreate it each week? With the new lastUpdated stuff it should be setup to only take the most recent set of standings, but I haven't tested it yet since I haven't had more than one week of standings.

Yes! Would be appending instead of replacing in the pandas to sql function

bsummy commented 8 months ago

I resolved the merge issues. If you're reviewing and the app doesn't look right, just run the create & insert in backend/sql in player_stats.db and restart the connection and it should work