search

neitanod / forceutf8

PHP Class Encoding featuring popular Encoding::toUTF8() function --formerly known as forceUTF8()-- that fixes mixed encoded strings.
1.63k stars 369 forks source link

Fix PHP 7.4 #86

Closed neoteknic closed 4 years ago

neoteknic commented 4 years ago

Fix php 7.4 ( array{$x} warning (error on frameworks). Strict === (better optimisation, fix softwarning on some IDE)

neoteknic commented 4 years ago

Hello, just merge to fix PHP7.4 ! Thank you

brusch commented 4 years ago

Experiencing the same issue - thanks for a quick fix :)

hanneskod commented 4 years ago

+1

stayallive commented 4 years ago

For people who currently cannot wait to update you can temporarily do the following in your composer.json.

    "require": {
-       "neitanod/forceutf8": "2.0.*",
+       "neitanod/forceutf8": "dev-patch-2#4d1466ff0844b2421605a163048dbdd3a1f8b021@dev",
    },
+   "repositories": [
+       {
+           "type": "vcs",
+           "url": "https://github.com/neoteknic/forceutf8.git"
+       }
+   ],

This will pull in the code from this PR after a composer update.

When this is merged and tagged you can revert these changes to go back to the normal release cycle.

neitanod commented 4 years ago

Thank guys! I'be been busy and didn't realize this issue was causing so many headaches. Now it's merged! Thanks for the support!

stayallive commented 4 years ago

@neitanod no worries, life happens! 😄

I assume your doing it as we speak but it also needs a tag for a new version to be pushed to packagist.

neitanod commented 4 years ago

Done! Thank you guys!

stayallive commented 4 years ago

Thanks @neitanod 👌

En thank you @neoteknic for making the PR in the first place.