fix: issue #216

[thorwhalen]

Replaced

 if args and (args[0] in cls.BASIC_TYPES):

with

 if args and (args[0] in cls.BASIC_TYPES):

[neithere]

Hi @thorwhalen, thank you for the report and the fix!

Could you please provide a minimal example to repro the bug? It would be great to update the unit tests along with the fix.

[thorwhalen]

Hi @thorwhalen, thank you for the report and the fix!

Could you please provide a minimal example to repro the bug? It would be great to update the unit tests along with the fix.

from typing import Optional, List

def func(x: Optional[List] = None):
        return 'hello'

if __name__ == '__main__':
    import argh

    argh.dispatch_command(func)

[thorwhalen]

Hi @thorwhalen, thank you for the report and the fix! Could you please provide a minimal example to repro the bug? It would be great to update the unit tests along with the fix.

from typing import Optional, List

def func(x: Optional[List] = None):
        return 'hello'

if __name__ == '__main__':
    import argh

    argh.dispatch_command(func)

Given this, perhaps my PR is not the right fix. Perhaps it's something to do with Optional[List] in particular (I tried Optional[Tuple] and it doesn't give me the same problem.

Note: I'm on python 3.10.13, on a mac.

[neithere]

Aha, thanks, got it! Optional[list] or list | None works but Optional[List] is broken. I'll take a closer look soon.

P.S.: if you don't need to support older Pythons, you can simply replace List with list.

[neithere]

Thank you Thor, the final fix was indeed a bit different (see 8f270d01c6) but your effort and your example have helped me pinpoint the exact problem and solve it there. Will ship the fix in 0.31.1 today.

[thorwhalen]

Great. Thanks. I'll update to 0.31.1 now.