search

neithernut / git-dit

Decentralized Issue Tracking for git
Other
457 stars 18 forks source link

Pre-collect names of local References in push_impl #151

Closed neithernut closed 7 years ago

neithernut commented 7 years ago

With git2-0.6.7, the signature of the References::names changed (see alexcrichton/git2-rs#245). The function now takes a mutable reference and imposes an additional lifetime constraint on the returned iterator. The latter can not out-life the References struct any more. This lead to compilation failures.

The problem is resolved by pre-collecting all names as Strings within a closure.

neithernut commented 7 years ago

Blocks virtually everything.