search

neithernut / pam_e4crypt

PAM module for unlocking transparently encrypted directories on ext4
GNU General Public License v2.0
19 stars 8 forks source link

Add keys to user keyring instead of session keyring #15

Closed seebaclo closed 7 years ago

seebaclo commented 7 years ago

As discussed in https://github.com/neithernut/pam_e4crypt/issues/14 . It fixes systemd setups. I tested this and it works as expected. I don't see any drawbacks of switching to user keyring. It's linked to session keyring by pam_keyinit automatically.

neithernut commented 7 years ago

Making the keyring used selectable would be acceptable. Switching the keys for all and every user is not. Especially if it's just for the sake of a systemd-use-case. Hence, I'll close this PR. However, I'll probably have the time to push a PR for making the keyring settable through an option next week. Sadly, I'll probably still don't have a good setup for automated tests by then.