nekochans / lgtm-cat-frontend

lgtm-cat(サービス名 LGTMeow https://lgtmeow.com) のフロントエンド用
https://lgtmeow.com
22 stars 2 forks source link

Node.jsのバージョンを18系に更新し依存Packageを最新安定版に更新 #234

Closed keitakn closed 1 year ago

keitakn commented 1 year ago

issueURL

https://github.com/nekochans/lgtm-cat-frontend/issues/231

関連 URL

https://lgtm-cat-frontend-git-feature-issue231upgrade-nodejs-nekochans.vercel.app/

Done の定義

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-zyaoyrynio.chromatic.com/

変更点概要

Node.jsのランタイムを18系に変更。READMEにNode.jsのインストール手順が載っていなかったので追記。

また依存Packageを最新安定版に更新を行っている。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

エラーページなどで favicon.ico が何故か404になるので public/favicon.ico を追加。

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 2:32PM (UTC)
codecov[bot] commented 1 year ago

Codecov Report

Base: 75.24% // Head: 75.24% // No change to project coverage :thumbsup:

Coverage data is based on head (c22ffbd) compared to base (597ec68). Patch has no changes to coverable lines.

:exclamation: Current head c22ffbd differs from pull request most recent head 67b1b4c. Consider uploading reports for the commit 67b1b4c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #234 +/- ## ======================================= Coverage 75.24% 75.24% ======================================= Files 52 52 Lines 501 501 Branches 132 132 ======================================= Hits 377 377 Misses 118 118 Partials 6 6 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.