keitakn commented 1 year ago

issueURL

https://github.com/nekochans/lgtm-cat-ui/issues/240

Done の定義

@nekochans/lgtm-cat-ui のバージョンが最新安定版に更新されている事

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-jbqacnwnlf.chromatic.com/

変更点概要

@nekochans/lgtm-cat-ui のバージョンを最新安定版に更新。

外から見た時の変更点はないが、Package内のBuildをVite4.0系で行われるようになったのと、Packageのファイル形式がESModuleだけになった点。

ESModuleになった関係でJestのテストが上手く動作しなくなってしまい色々試行錯誤したが、改修範囲が大きそうなので、Result型などは @nekochans/lgtm-cat-ui に依存しない形に変更した。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
lgtm-cat-frontend	✅ Ready (Inspect)	Visit Preview	Dec 13, 2022 at 6:34AM (UTC)

codecov[bot] commented 1 year ago

Codecov Report

Base: 75.24% // Head: 75.29% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (2394f84) compared to base (c064676). Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #236 +/- ## ========================================== + Coverage 75.24% 75.29% +0.04% ========================================== Files 52 52 Lines 501 510 +9 Branches 132 134 +2 ========================================== + Hits 377 384 +7 - Misses 118 120 +2 Partials 6 6 ``` | [Impacted Files](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans) | Coverage Δ | | |---|---|---| | [src/features/result.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL2ZlYXR1cmVzL3Jlc3VsdC50cw==) | `85.71% <85.71%> (-14.29%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nekochans / lgtm-cat-frontend

@nekochans/lgtm-cat-ui のバージョンを最新安定版の v2.2.7 にアップグレード #236