search

nekochans / lgtm-cat-frontend

lgtm-cat（サービス名 LGTMeow https://lgtmeow.com) のフロントエンド用
https://lgtmeow.com
21 stars 2 forks source link

不要な環境変数が残っていたり、必要な環境変数がREADMEに追加されていなかったりしたので修正 #243

Closed keitakn closed 1 year ago

keitakn commented 1 year ago

issueURL

https://github.com/nekochans/lgtm-cat-frontend/issues/237

関連 URL

https://lgtm-cat-frontend-git-feature-issue237delete-env-nekochans.vercel.app

Done の定義

Storybook の URL もしくはスクリーンショット

UI変更はないのでなし。

変更点概要

以下の修正を実施。

VercelやGitHubActionsに残っていた不要な環境変数に関しても削除済。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

環境変数を削除したので、念の為GAのイベントなどがちゃんと送信されているか確認したが特に問題なく動作している様子だった。

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview Jan 18, 2023 at 8:48AM (UTC)
codecov[bot] commented 1 year ago

Codecov Report

Base: 75.16% // Head: 75.16% // No change to project coverage :thumbsup:

Coverage data is based on head (f2f2998) compared to base (7a41312). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #243 +/- ## ======================================= Coverage 75.16% 75.16% ======================================= Files 48 48 Lines 463 463 Branches 126 126 ======================================= Hits 348 348 Misses 111 111 Partials 4 4 ``` | [Impacted Files](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans) | Coverage Δ | | |---|---|---| | [src/features/url.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL2ZlYXR1cmVzL3VybC50cw==) | `86.95% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.