keitakn commented 1 year ago

issueURL

https://github.com/nekochans/lgtm-cat-ui/issues/258

Done の定義

https://github.com/nekochans/lgtm-cat-ui/issues/258 のDoneの定義を満たしている事

Storybook の URL もしくはスクリーンショット

日本語

英語

変更点概要

https://github.com/nekochans/lgtm-cat-ui/pull/263 でUI側の改修を行ったので @nekochans/lgtm-cat-ui を最新安定版にアップグレード。

大きな画像をアップロードするとフロントエンド側でバリデーションが正常に行われる事を確認済。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
lgtm-cat-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 30, 2023 at 1:53PM (UTC)

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (8e523cd) 75.21% compared to head (738b8e2) 75.21%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #248 +/- ## ======================================= Coverage 75.21% 75.21% ======================================= Files 48 48 Lines 464 464 Branches 139 139 ======================================= Hits 349 349 Misses 111 111 Partials 4 4 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nekochans / lgtm-cat-frontend

画像サイズが大きい場合はUI側でエラーメッセージを表示させる対応を実施 #248