search

nekochans / lgtm-cat-frontend

lgtm-cat（サービス名 LGTMeow https://lgtmeow.com) のフロントエンド用
https://lgtmeow.com
21 stars 2 forks source link

tsconfig.json の内容を create-next-app の最新版で生成される内容に変更 #250

Closed keitakn closed 1 year ago

keitakn commented 1 year ago

issueURL

https://github.com/nekochans/lgtm-cat-frontend/issues/222

関連 URL

https://lgtm-cat-frontend-git-feature-issue222fix-tsco-ae75f9-nekochans.vercel.app

Done の定義

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-jxbycdiunr.chromatic.com

変更点概要

tsconfig.json の内容を最新の create-next-app で生成される内容に置き換え。

これによって import { ErrorLayout } from '@/layouts'; のようにimportを行う事が出来るようになったのでリファクタリングを実施。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 2:08pm
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.99 :warning:

Comparison is base (cbafa55) 75.21% compared to head (3e120d4) 74.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #250 +/- ## ========================================== - Coverage 75.21% 74.22% -0.99% ========================================== Files 48 48 Lines 464 454 -10 Branches 139 113 -26 ========================================== - Hits 349 337 -12 - Misses 111 113 +2 Partials 4 4 ``` | [Impacted Files](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans) | Coverage Δ | | |---|---|---| | [src/hooks/createErrorMessages.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL2hvb2tzL2NyZWF0ZUVycm9yTWVzc2FnZXMudHM=) | `100.00% <ø> (ø)` | | | [src/api/fetch/lgtmImage.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL2FwaS9mZXRjaC9sZ3RtSW1hZ2UudHM=) | `85.71% <100.00%> (-0.40%)` | :arrow_down: | | [src/features/metaTag.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL2ZlYXR1cmVzL21ldGFUYWcudHM=) | `21.12% <100.00%> (ø)` | | | [src/hooks/useCatImageUploader.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL2hvb2tzL3VzZUNhdEltYWdlVXBsb2FkZXIudHM=) | `91.66% <100.00%> (-4.34%)` | :arrow_down: | | [src/hooks/useCatImageValidator.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL2hvb2tzL3VzZUNhdEltYWdlVmFsaWRhdG9yLnRz) | `94.59% <100.00%> (-0.15%)` | :arrow_down: | | [src/hooks/useCatImagesFetcher.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL2hvb2tzL3VzZUNhdEltYWdlc0ZldGNoZXIudHM=) | `100.00% <100.00%> (ø)` | | | [src/mocks/api/error/mockInternalServerError.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL21vY2tzL2FwaS9lcnJvci9tb2NrSW50ZXJuYWxTZXJ2ZXJFcnJvci50cw==) | `100.00% <100.00%> (ø)` | | | [src/mocks/api/error/mockUnauthorizedError.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL21vY2tzL2FwaS9lcnJvci9tb2NrVW5hdXRob3JpemVkRXJyb3IudHM=) | `50.00% <100.00%> (-25.00%)` | :arrow_down: | | [.../mocks/api/external/lgtmeow/mockFetchLgtmImages.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL21vY2tzL2FwaS9leHRlcm5hbC9sZ3RtZW93L21vY2tGZXRjaExndG1JbWFnZXMudHM=) | `100.00% <100.00%> (ø)` | | | [...c/mocks/api/external/lgtmeow/mockUploadCatImage.ts](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans#diff-c3JjL21vY2tzL2FwaS9leHRlcm5hbC9sZ3RtZW93L21vY2tVcGxvYWRDYXRJbWFnZS50cw==) | `100.00% <100.00%> (ø)` | | | ... and [9 more](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans) | | ... and [6 files with indirect coverage changes](https://codecov.io/gh/nekochans/lgtm-cat-frontend/pull/250/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nekochans)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.