search

nekochans / lgtm-cat-frontend

lgtm-cat（サービス名 LGTMeow https://lgtmeow.com) のフロントエンド用
https://lgtmeow.com
21 stars 2 forks source link

各URLをApp Routerへ移行 #286

Closed keitakn closed 6 months ago

keitakn commented 6 months ago

issueURL

https://github.com/nekochans/lgtm-cat-frontend/issues/281

関連 URL

https://lgtm-cat-frontend-git-feature-issue281app-router-nekochans.vercel.app/

このPRで対応すること / このPRで対応しないこと

全てのルーティングをApp Routerへ移行する。

App Router向けのComponentの再設計やi18n対応に関してはこのPRでは実装せずに別PRで対応する。

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-mchgsmcxwc.chromatic.com/

変更点概要

アプリケーションのルーティング方法をApp Routerへ移行。

現時点では i18n 対応は未対応なので日本語のページしか閲覧出来ない。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2024 8:30am
codecov[bot] commented 6 months ago

Codecov Report

Attention: 355 lines in your changes are missing coverage. Please review.

Comparison is base (dfc2856) 28.57% compared to head (b113390) 24.82%. Report is 1 commits behind head on release/v2.8.0.

Files Patch % Lines
src/utils/gtm.ts 0.00% 42 Missing :warning:
src/app/terms/page.tsx 0.00% 34 Missing and 1 partial :warning:
src/app/layout.tsx 0.00% 33 Missing and 1 partial :warning:
src/app/privacy/page.tsx 0.00% 33 Missing and 1 partial :warning:
src/components/ErrorContent/RetryButton.module.css 0.00% 32 Missing and 1 partial :warning:
src/components/ErrorContent/RetryButton.tsx 0.00% 31 Missing and 1 partial :warning:
src/app/error.tsx 0.00% 26 Missing and 1 partial :warning:
...rc/components/ErrorContent/RetryButton.stories.tsx 0.00% 24 Missing and 1 partial :warning:
src/app/maintenance/page.tsx 0.00% 15 Missing and 1 partial :warning:
src/app/page.tsx 0.00% 12 Missing and 1 partial :warning:
... and 13 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/v2.8.0 #286 +/- ## ================================================== - Coverage 28.57% 24.82% -3.75% ================================================== Files 214 215 +1 Lines 6699 7735 +1036 Branches 269 271 +2 ================================================== + Hits 1914 1920 +6 - Misses 4626 5655 +1029 - Partials 159 160 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.