search

nekochans / lgtm-cat-frontend

lgtm-cat（サービス名 LGTMeow https://lgtmeow.com) のフロントエンド用
https://lgtmeow.com
21 stars 2 forks source link

Storybookを8系の最新にアップグレード #315

Closed keitakn closed 4 months ago

keitakn commented 4 months ago

issueURL

https://github.com/nekochans/lgtm-cat-frontend/issues/312

関連 URL

https://lgtm-cat-frontend-git-feature-issue312upgrade-f710ac-nekochans.vercel.app/

このPRで対応すること / このPRで対応しないこと

Storybookを8系の最新にアップグレードします。

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-wgeoqlnofo.chromatic.com/

変更点概要

Storybookを8系の最新にアップグレード。

具体的な変更内容は以下のPRで対応した内容と同じ。

https://github.com/nekochans/ai-cat-frontend/pull/86

https://zenn.dev/link/comments/a7a46e40d0fcb5 に記載した通り storybook dev で起動した場合一部不具合と思われる現象が起きているが通常利用に影響はないので一旦このまま利用する事にする。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 9:02am
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 21.84%. Comparing base (d118afe) to head (67ffd6e).

Files Patch % Lines
...nts/CatImages/InternalServerErrorImage.stories.tsx 0.00% 4 Missing and 1 partial :warning:
...ents/CatImages/ServiceUnavailableImage.stories.tsx 0.00% 4 Missing and 1 partial :warning:
...ents/MarkdownContents/MarkdownContents.stories.tsx 0.00% 4 Missing and 1 partial :warning:
...ontentsWrapper/MarkdownContentsWrapper.stories.tsx 0.00% 3 Missing :warning:
...s/Button/CatButtonGroup/CatButtonGroup.stories.tsx 0.00% 2 Missing :warning:
...s/Button/CatFetchButton/CatFetchButton.stories.tsx 0.00% 2 Missing :warning:
...atRandomCopyButton/CatRandomCopyButton.stories.tsx 0.00% 2 Missing :warning:
...on/GitHubLoginButton/GitHubLoginButton.stories.tsx 0.00% 2 Missing :warning:
...Button/UploadCatButton/UploadCatButton.stories.tsx 0.00% 2 Missing :warning:
src/components/CatImages/NotFoundImage.stories.tsx 0.00% 1 Missing and 1 partial :warning:
... and 17 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #315 +/- ## ========================================== - Coverage 21.84% 21.84% -0.01% ========================================== Files 242 242 Lines 9740 9742 +2 Branches 302 302 ========================================== Hits 2128 2128 - Misses 7432 7434 +2 Partials 180 180 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.