search

nekocode / CameraFilter

📷 Realtime camera filters on android.
Apache License 2.0
2.14k stars 363 forks source link

APK files in releases show wrong version number #4

Closed IzzySoft closed 8 years ago

IzzySoft commented 8 years ago

For the 1.4 release, the APK still shows 1.4:

package: name='cn.nekocode.camerafilter' versionCode='1' versionName='1.0'

Could you please upload a fixed version, and keep numbers in sync? Thanks in advance!

nekocode commented 8 years ago

Yes, I will fix them in the next version. Thanks for your suggestion.

IzzySoft commented 8 years ago

Thanks a lot! Please let me know then (I'll leave this issue open for that purpose). I'd really like to include your app with my repo, if that's OK with you :)

nekocode commented 8 years ago

Yes, of course that's OK. I have already fixed it just now, you can take a look at the 1.5 version.

IzzySoft commented 8 years ago

Thanks a lot! Here you go ;) Maybe you also want to add some license information – if you already chose a license, that is?

PS: If you want me to add/change something to the description, let me know. I basically copied the details from the README.md of the project.

nekocode commented 8 years ago

Thanks for your reminder, I had already declared the license for this project at the top of README.md (see the badge).

IzzySoft commented 8 years ago

Ouch :see_no_evil: Sorry, sure. I was looking for some License.* file. As those badges at that position in most cases show results from build processes etc, I've started ignoring them...

Thanks again!

IzzySoft commented 8 years ago

Um, it just happened again: v2.1.1 and v2.2 have the same versionCode:

package: name='cn.nekocode.camerafilter' versionCode='211' versionName='2.1.1' platformBuildVersionName='6.0-2704002'
package: name='cn.nekocode.camerafilter' versionCode='211' versionName='2.2' platformBuildVersionName=''

To not have my repo stuck, I've removed v2.1.1 manually. Please ensure to update both, versionCode and versionName when releasing a new version :)

nekocode commented 8 years ago

@IzzySoft Ok, I will remember it ~