search

nekohayo / specto

Automatically exported from code.google.com/p/specto
0 stars 0 forks source link

crash when deleting a watch during the first update process or after clearing all watches #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. start Specto
2. during the refresh, edit a watch and delete it
3. watch Specto crash

Original issue reported on code.google.com by nekoh...@gmail.com on 12 Nov 2006 at 9:46

GoogleCodeExporter commented 9 years ago 
In my opinion this could be a more general problem. I deleted some watches that 
I had
been using before for quite some time. This was not during an update process.
Specto crashed the next time I started it again. 
Then I started it from the (idle-) python shell and got: KeyError at line 176 in
watch.py (values['type'] = int(watch_options['type']). As far as I understand 
the
program is here evaluating the file watches.list in .specto.
I add my watches.list as attachment. The first entry is the watch that is still
valid, the other four had been deleted by me. As you can see, the deleted 
watches are
still there, but lack the setting for type which might have caused the KeyError.

Hope this makes sense and is the right place to post it.

Original comment by knut.ger...@alice-dsl.net on 13 Nov 2006 at 6:34

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by nekoh...@gmail.com on 15 Nov 2006 at 12:07

GoogleCodeExporter commented 9 years ago 
Another way to reproduce the problem:
1. Start Specto and open the notifier window
2. Add a watch for http://specto.ecchi.ca/test/
3. Add a watch for http://www.google.com/
4. Press the "Update"-button (Check-button?, Refresh-button?, I only see it in
German) in the notifier window until it is indicated, that
http://specto.ecchi.ca/test/ has been updated
5. Remove the watch for http://www.google.com/
6. Press the "Clear all" button
7. Close the notifier window
8. Exit Specto
Your watch.list is now corrupt i.e. contains the lines
[google]
updated = False
and the next time you start Specto it will crash

Original comment by knut.ger...@alice-dsl.net on 15 Nov 2006 at 3:00

GoogleCodeExporter commented 9 years ago 
Indeed, I remember this problem that I see in your watches.list. But I thought 
that
particular case was fixed. Following your very detailed (thanks!) instructions 
in
your comment, I was indeed able to reproduce it:

jeff@khloe:~/trunks/specto$ ./launch.sh 
DEBUG - main.Specto  - add watch: create
INFO - watch_web_static.Web_watch - Updating watch: "test"
INFO - main.Specto  - watch "test" started
DEBUG - main.Specto  - add watch: recreate
INFO - watch_web_static.Web_watch - Updating watch: "google"
INFO - main.Specto  - watch "google" started
INFO - main.Specto  - watch "google" stopped
INFO - watch_web_static.Web_watch - Updating watch: "google"
INFO - watch_web_static.Web_watch - Difference percentage:0.0 (Watch: "google")
INFO - main.Specto  - watch "google" started
INFO - main.Specto  - watch "test" stopped
INFO - watch_web_static.Web_watch - Updating watch: "test"
INFO - watch_web_static.Web_watch - Difference percentage:34.20 (Watch: "test")
INFO - watch_web_static.Web_watch - Watch "test" updated!
INFO - main.Specto  - watch "test" started

[this is the part where I remove the "google" watch]
DEBUG - main.Specto  - edit watch: create
INFO - main.Specto  - watch "google" stopped
/home/jeff/trunks/specto/src/specto/notifier.py:141: GtkWarning:
gtk_list_store_set_value: assertion `VALID_ITER (iter, list_store)' failed
  self.model.set_value(self.iter[i], 2, "%s" % self.specto.watch_db[i].name)
/home/jeff/trunks/specto/src/specto/notifier.py:151: GtkWarning:
gtk_list_store_set_value: assertion `VALID_ITER (iter, list_store)' failed
  self.model.set_value(self.iter[i], 1, icon)

This will only happen IF you clear ALL the watches AFTER removing one. If I 
clear a
watch individually, it will not do such corruption. The reason is that it tries 
to
clear a watch that doesn't exist anymore, and I don't remember why it does that.
Marking as high priority, as it causes corruption.

I am not sure if this and the original bug report are the same issue. If we are
lucky, fixing your problem could fix everything...

Original comment by nekoh...@gmail.com on 15 Nov 2006 at 5:33

GoogleCodeExporter commented 9 years ago 
Fixed in SVN revision 3 :) could you try it out and see if it is fixed for you 
now?

Original comment by nekoh...@gmail.com on 15 Nov 2006 at 6:26

GoogleCodeExporter commented 9 years ago 
nekohayo, are you talking to me? I would first have to install svn and learn 
more
about it. Knut

Original comment by knut.ger...@alice-dsl.net on 16 Nov 2006 at 3:35

GoogleCodeExporter commented 9 years ago 
Yes, I don't know what Linux distribution you are using, but if you are on 
ubuntu or
debian you just need to install the package called "subversion", you can then 
use the
commands from http://code.google.com/p/specto/source to grab the svn specto 
version.

Then, you would just need to run launch.sh

Original comment by nekoh...@gmail.com on 16 Nov 2006 at 6:01

GoogleCodeExporter commented 9 years ago 
Cool. It did work out, the launch as well as the test. By the way it's ubuntu.

Original comment by knut.ger...@alice-dsl.net on 16 Nov 2006 at 9:40

GoogleCodeExporter commented 9 years ago 
Oooold bug needs to die :)

Original comment by nekoh...@gmail.com on 18 Mar 2008 at 1:30