nekohayo / specto

Automatically exported from code.google.com/p/specto
0 stars 0 forks source link

Google Reader notifier can't find internet-news-reader icon #88

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When I try to start specto (current SVN version) after adding a google
reader account, if it can't find the internet-news-reader icon in the
current icon theme, it will crash with the error:

File "/usr/bin/specto", line 38, in <module>
    specto = Specto()
  File "/usr/lib/python2.5/site-packages/spectlib/main.py", line 124, in
__init__
    self.create_all_watches(watch_value_db)
  File "/usr/lib/python2.5/site-packages/spectlib/main.py", line 201, in
create_all_watches
    self.create_watch(value_db[i])
  File "/usr/lib/python2.5/site-packages/spectlib/main.py", line 270, in
create_watch
    self.notifier.add_notifier_entry(values['name'], values['type'], id)
  File "/usr/lib/python2.5/site-packages/spectlib/notifier.py", line 306,
in add_notifier_entry
    icon = self.specto.icon_theme.load_icon("internet-news-reader", 22, 0)

When I change the icon theme to one that does have this icon (like Dropline
Neu), it will load. But since the default gnome icon theme doesn't have
this icon available, maybe it's good if the icon applications-system is
used instead (since this is a default icon) if the news-reader icon is not
available.

Also, could someone tell me how to circumvent the problem, so I can keep
using the gnome icons?

Original issue reported on code.google.com by me.g...@gmail.com on 27 Dec 2007 at 11:54

GoogleCodeExporter commented 9 years ago
I added a workaround for this in svn revision 127, could you test if it works? 
And,
anyone, feel free to comment on the hackyness of this fix, I'm not sure it was 
the
proper way to do it.

Original comment by nekoh...@gmail.com on 28 Dec 2007 at 3:56

GoogleCodeExporter commented 9 years ago
It does work now, thanks for the fix!
I also looked into the diff, and it doesn't look like it's a very ugly fix, 
although
maybe you could use a string (where the value is the result of the check, either
"internet-news-reader" or "applications-internet" instead? (not sure about 
this, I'm
not that much into python, and also not at all into the codebase of this 
project ;) ).

Original comment by me.g...@gmail.com on 28 Dec 2007 at 4:15

GoogleCodeExporter commented 9 years ago
thanks!

Original comment by nekoh...@gmail.com on 30 Dec 2007 at 2:05

GoogleCodeExporter commented 9 years ago

Original comment by nekoh...@gmail.com on 18 Mar 2008 at 2:40