nekomangaorg / Neko

Unofficial MangaDex Reader for Android 7+
Apache License 2.0
2.15k stars 112 forks source link

Library updates skipped notification is shown on "error" channel. #1769

Closed AllenJB closed 3 months ago

AllenJB commented 3 months ago

Steps to reproduce

  1. Configure library updates to exclude some items (eg. complete).
  2. Run library update and get skipped message
  3. Long-press notification and see it's in the Errors library sub-channel instead of Skipped

Expected behavior

Disabling the Skipped Library notification sub-channel should silence skipped update notification.

Actual behavior

Skipped updates notification is still shown because it's on the Errors sub-channel.

Crash logs

N/A

Neko version

2.16.3

Android version

Android 14

Device

Google Pixel 7

Other details

I believe the error is here: https://github.com/nekomangaorg/Neko/blob/4f26a47eddb76d9e1acc09c200e660fd600e868d/app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateNotifier.kt#L147

This should send to CHANNEL_LIBRARY_SKIPPED instead (ref: https://github.com/nekomangaorg/Neko/blob/4f26a47eddb76d9e1acc09c200e660fd600e868d/app/src/main/java/eu/kanade/tachiyomi/data/notification/Notifications.kt#L75 )

Acknowledgements