nektos / act-environments

MIT License
69 stars 29 forks source link

[WIP] Update existing images and add Ubuntu 20.04 #5

Closed lumaxis closed 3 years ago

lumaxis commented 4 years ago

Closes #4

I wanted to update the images with the latest state from https://github.com/actions/virtual-environments and tried to deduce the necessary changes from the current versions of the ubuntu*.json files here.

lumaxis commented 4 years ago

My test build of the images is still running, so don't yet know if they actually work – hence the [WIP] tag 😬

cplee commented 4 years ago

let me know what the results show @lumaxis 🤞

lumaxis commented 4 years ago

I think my Docker disk ran out of disk space 😆 Trying again!

cplee commented 4 years ago

@lumaxis fwiw, I did my building of images on an AWS Cloud9 instance

alxs commented 3 years ago

@lumaxis did you manage to get this running? Ubuntu 20.04 is currently being rolled out as the default for ubuntu-latest workflows.

lumaxis commented 3 years ago

Unfortunately I never did and currently don't really have the capacity to work on this further 😕 If anyone wants to build on top of this work and continue my quest, please feel free 🙏🏼

catthehacker commented 3 years ago

you can try catthehacker/ubuntu:full-20.04 which is only few months old

shuhaowu commented 3 years ago

Where's that image built from? I can't find the source?

catthehacker commented 3 years ago

It was built from Dockerfile I wrote based on the ubuntu2004.json Packer template and scripts from https://github.com/actions/virtual-environments but the source Dockerfile is not available anymore

gene1wood commented 3 years ago

Given that the main act README ( https://github.com/nektos/act#runners ) suggests users use @catthehacker 's hosted docker images as of nektos/act#463 ( whoops, actually nektos/act#523 ) , and those include an image for Ubuntu 20.04 ( ghcr.io/catthehacker/ubuntu:act-20.04 ) which comes from https://github.com/catthehacker/docker_images should this PR be closed?

Should @catthehacker PR in his solution to this into this nektos repo?

lumaxis commented 3 years ago

should this PR be closed?

Yes, I think so.

catthehacker commented 3 years ago

Should @catthehacker PR in his solution to this into this nektos repo?

If you mean medium images I can just transfer the repo and if desirable, images could be published on Nektos Docker Hub/GitHub Container Registry. Also act-20.04 and other versions/variants don't include full set of tools that GitHub runner does (they are meant to be most compatible with minimum required tools installed), full-latest/full-20.04/full-18.04 should be most "tool-complete" since it's built from the Packer template (https://github.com/catthehacker/virtual-environments-fork/tree/master/images/linux). I'm also planning to do slim/lite version that has most but not all tools/multiple versions of tools (like act-environments-ubuntu:18.04-lite that is sort of a middle ground between massive image and small images, but haven't had the time yet due to health issues.

nektos/act#463

I think you meant https://github.com/nektos/act/pull/523 :)