search

nektos / act

Run your GitHub Actions locally 🚀
https://nektosact.com
MIT License
51.87k stars 1.3k forks source link

fix: composite action input pollution #2348

Closed ChristopherHX closed 3 weeks ago

ChristopherHX commented 3 weeks ago

The full shape of this bug not yet discovered, it's big and needs tests

and act refuses to use the default for an nodejs input when an composite action has an input with the same name

Fixes #2243

github-actions[bot] commented 3 weeks ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 4 0 0.02s
✅ REPOSITORY gitleaks yes no 2.38s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 7.7s
✅ REPOSITORY secretlint yes no 1.32s
✅ REPOSITORY trivy-sbom yes no 0.64s
✅ REPOSITORY trufflehog yes no 4.3s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

ChristopherHX commented 3 weeks ago

My outstanding task here is writing tests, please remind me if I forget that.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.31%. Comparing base (5a80a04) to head (885a7b9). Report is 79 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2348 +/- ## =========================================== + Coverage 61.56% 76.31% +14.75% =========================================== Files 53 61 +8 Lines 9002 7811 -1191 =========================================== + Hits 5542 5961 +419 + Misses 3020 1295 -1725 - Partials 440 555 +115 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.