nektos / act

Run your GitHub Actions locally 🚀
https://nektosact.com
MIT License
51.87k stars 1.3k forks source link

fix: changed location of actrc in info message #2373

Open just-dev-creator opened 1 week ago

just-dev-creator commented 1 week ago

Hi there, when trying to switch the docker image used for one of my projects, I noticed that the .actrc file is not in the path stated during setup (~/.actrc), but rather in ~/.config/act/actrc. I changed the info text accordingly. I hope this isn't some special thing when using act via the AUR or something like that, but at least for me it took some minutes to find the correct config. If this issue is specific to me, please just close this PR - I certainly don't have enough knowledge of Go to find the code part that creates the config and investigate further.

ChristopherHX commented 1 week ago

That path got os dependent since an outside contributor changed the preference order and now we are here at the side effects

We should put the actual filepath used for writing instead of hardcoding an now os dependent value.

should be the result of configLocations()[0], but please check for len >= 1 to make this never crash

act --bug-report has always shown the whole list of config locations which were created by either by hand or automatically

just-dev-creator commented 1 week ago

Perfect, I will try to copy the functionality of the bug-report command to this info message. Thank you very much for your near-instant reply.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.32%. Comparing base (5a80a04) to head (4e1b6c1). Report is 85 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2373 +/- ## =========================================== + Coverage 61.56% 76.32% +14.76% =========================================== Files 53 61 +8 Lines 9002 7815 -1187 =========================================== + Hits 5542 5965 +423 + Misses 3020 1295 -1725 - Partials 440 555 +115 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.