search

nektra / Deviare-InProc

Deviare In Process Instrumentation Engine
http://nektra.com/products/deviare-api-hook-windows/deviare-in-process/
Other
328 stars 83 forks source link

In-Proc does not fix relative jumps in trampoline functions #22

Closed bo3b closed 6 years ago

bo3b commented 6 years ago

Please see: https://github.com/bo3b/3Dmigoto/issues/87

In this specific case, the JNE instruction is moved into the stub, and is not fixed there, which means it's a relative jne to nowhere.

Tested in top-of-tree, and bug still exists.

mxmauro commented 6 years ago

Hi @bo3b and @DarkStarSword, I've implemented the changes. Currently testing. I'll use this issue to notify about changes.

mxmauro commented 6 years ago

Uploaded changes. Please let me know if they work for you.

DarkStarSword commented 6 years ago

Excellent - I've tested the VSSetSamplers case and can confirm this is working for me :)

I'll do some more smoke screen testing on the other hooks, but I think this is resolved and we can close the bug - thanks :)

bo3b commented 6 years ago

Yes, looking good.

Thanks very much for the quick response.

mxmauro commented 6 years ago

Excellent guys.

Kind regards.