search

nektra / Deviare-InProc

Deviare In Process Instrumentation Engine
http://nektra.com/products/deviare-api-hook-windows/deviare-in-process/
Other
328 stars 83 forks source link

Doesn't build? #7

Closed bo3b closed 8 years ago

bo3b commented 8 years ago

If I do a git clone of the repository, the project structure does not seem to match the code.

Looking just at NktHookLib to be built, I get:

1>..\Lib\libudis86\amalgamation.c(33): fatal error C1083: Cannot open include file: 'source\libudis86\decode.h': No such file or directory

amalgamation.c has includes of:

#include "stdint.h"
#include "source\libudis86\decode.h"
#include "source\libudis86\extern.h"

And the path source\libudis86\ does not exist.

Here is how the hierarchy looks:

image

Decode.h is under tables not source and in any case is under `libudis86 not above it.

image

Visual Studio 2013.

I'm sure I can get it building, I just figured you might want to know.

bo3b commented 8 years ago

Hmmm... I see. Submodules. Not my favorite.

Please add a note to your front page ReadMe, that makes it clear that you have to do git clone --recursive for this to work.

Your instructions in INSTALLATION & USAGE are incomplete.

scnale commented 8 years ago

Fixed in 11b39d7ead74ce75ba.

bo3b commented 8 years ago

Cool, thanks for making that more clear.