search

nel-lab / mesmerize-core

High level pandas-based API for batch analysis of Calcium Imaging data using CaImAn
Other
58 stars 15 forks source link

More changes for nested parameters #299

Closed ethanbb closed 1 month ago

ethanbb commented 2 months ago

This has a couple of minor changes. The first is necessary for motion correction to work when parameters are passed as a nested dictionary. The code was assuming that params["main"] contains "pw_rigid", which is not true if it's nested under "motion". Instead of dealing with both cases, I just switched it to reading the parameter from the params object.

The second is less important. I was looking for other places where the structure of params["main"] is assumed, and found this piece of code that converts lists to tuples. This should no longer be necessary now that get_params_diffs allows non-hashable parameter values (assuming that the comment about why it is there is accurate), so I removed it.

There are 2 failing tests, but I believe they are the same ones that have been failing consistently.

kushalkolar commented 2 months ago

There are 2 failing tests, but I believe they are the same ones that have been failing consistently.

Yea caiman made a change about a year ago that broke the tests, we don't have anyone to work further on this. My focus is currently on developing new algorithms so this repo is maintained but my time is limited, the other devs have also moved onto other projects, Caitlin (who wrote the entire test suite) and I now focus on https://github.com/fastplotlib/fastplotlib which is very useful for neuroscience viz.