nelc / futurex-openedx-extensions

Open edX APIs and reporting tools
Other
0 stars 0 forks source link

Course listing details is hiding non-visible courses #12

Closed shadinaif closed 5 days ago

shadinaif commented 5 months ago

https://github.com/nelc/futurex-openedx-extensions/blob/5c1c0c8aa08d21c206424c0c2f3d4a8cfef1da61/futurex_openedx_extensions/dashboard/views.py#L129

this should not hide non-visible courses. And must add a visibility field to the response

Also course statuses must show count of hiden separately

OmarIthawi commented 4 months ago

@shadinaif this is still the case on production, please check:

image

OmarIthawi commented 4 months ago

The courses page is great. It shows the important courses first. However, we'd like to show the other (hidden from students) courses below so authors can use this instead of Studio.

@shadinaif so regarding the course list it's a bug in production.

Please fix after the Student Course details:

Details ![image](https://github.com/nelc/futurex-openedx-extensions/assets/645156/d5386c22-7d4a-4d9e-83d3-0c5d29e28a54)

If you think the solution is complex, please ping Faris or Ahmed on Slack to discuss the possible UX implications.

OmarIthawi commented 4 months ago

Still a bug in production @shadinaif with v0.3.4:

image

shadinaif commented 3 months ago

resolved here https://github.com/nelc/futurex-openedx-extensions/pull/33 v0.4.2

OmarIthawi commented 1 month ago

@shadinaif please check it out in production.