nelenkov / android-backup-extractor

Android backup extractor
Other
2.24k stars 275 forks source link

Bad advice in the README.md #39

Open cparke2 opened 8 years ago

cparke2 commented 8 years ago

This is a great utility you've created that is working well for me on Mac OS X. However, when rebuilding the archive, you advised in the readme file to use "tar tf backup.tar | grep -F "com.package.name" >package.list" to store off the original order of the files to be used subsequently with "tar cf restore.tar -T package.list" when creating the new tar file to pack,

There is a big problem with this suggestion: tar includes subdirectory names as well as files in the package.list file! When you go to recreate the tar using that list file, all the files in the subdirectories get added multiple times! (once for the directory listings, and again for the file listings). Talk about bloat! Not to mention the exact file ordering is not preserved for the subdirectories because they are added for the subdirectory listing first. There isn't an easy way to fix this, the subdirectories need to be filtered out of the package.list somehow and tar doesn't provide such an option, for now I'm using a bash shell script to repair the list.

nelenkov commented 8 years ago

Someone contributed that part, care to submit a 'fix' (pull request) for the README?

cparke2 commented 8 years ago

Ready for review

tomaszn commented 8 years ago

@cparke2 Could you please provide your shell script to repair the list?

cpfeiffer commented 7 years ago

His commit is at https://github.com/cparke2/android-backup-extractor/commit/ec804f65fdf62babd94ba795330c8713090b1e3d

rustyx commented 3 years ago

Check out my fork, it has built-in support to pack/unpack a .tar file.

Einxeld commented 1 year ago

Check out my fork, it has built-in support to pack/unpack a .tar file.

MAN YOU ARE A LIFESAVER Thank you very much for your repo, only your solution for .tar packing worked and is very cool and easy to use!