search

nelenkov / android-backup-extractor

Android backup extractor
Other
2.24k stars 275 forks source link

Updates and cleanups #91

Closed ThexXTURBOXx closed 2 years ago

ThexXTURBOXx commented 2 years ago

Updates Gradle, BouncyCastle and cleanup all the build scripts and so on

nelenkov commented 2 years ago

Thanks for this! Looks good overall, but can we keep the formatting changes to code to a minimum (parameters list newlines, spelling, variable init, etc.). The idea was to keep this close to the original code, so a lot of this comes from there.

I can comment on the PR directly if that makes it easier.

Question: any reason to add Maven publishing? IIRC, not used at the moment.

ThexXTURBOXx commented 2 years ago

You're more than welcome! I reverted most of the style changes. Is it okay like this or should I revert some more?

I added the maven-publish plugin for Jitpack to work properly. It could be done via the .jitpack.yml file as well, but it's not as clean as this. It won't impact "normal" builds (you have to execute the publishToMaven* tasks yourself in order to make it work), so that's okay, I guess?

nelenkov commented 2 years ago

Thanks, looks good. If you could reduce the pom.xml reformatting so it obvious what changed, even better. If that's hard to do, I can merge as is as well.

ThexXTURBOXx commented 2 years ago

Changed pom.xml formatting back :) Such changes are very easy to make. You just do a soft reset to before your commit, discard all changes within that file and apply them yourself again :)

nelenkov commented 2 years ago

Thanks!